magmodules / magento2-sooqr

Sooqr Connect for Magento® 2
https://www.magmodules.eu/sooqr-connect.html
Other
2 stars 3 forks source link

Product enabled status only checked for default storeview #71

Closed npluimers closed 5 months ago

npluimers commented 5 months ago

Describe the bug Products that are enabled on default, and disabled on a specific storeview are being included in the product feed, causing missing products.

Used versions

To Reproduce Steps to reproduce the behavior:

  1. Add Product A, enabled on default, and disable on one storeview
  2. Generate feeds
  3. Check feed of storeview where product A is disabled

Expected behavior Product A is not included in the feed since the product is not enabled on the specific storeview

Actual behavior Product A is included in the feed

Additional context We have created a patch: https://gist.github.com/npluimers/f8d6475369514d34629af8d620ce3353

Marvin-Magmodules commented 5 months ago

Hi @npluimers, thank you for opening this issue and also supplying the patch! Just released v2.1.2 that includes this patch. We added some extra code to this patch to also check for visibility fallback on default store, as while testing we found out that part was still not working properly.

We are closing this issue now but please feel free to reopen if it doesn't fit your needs.