magnars / dash.el

A modern list library for Emacs
GNU General Public License v3.0
1.67k stars 138 forks source link

Fix bug with -is-suffix? #384

Closed brennier closed 3 years ago

brennier commented 3 years ago

The current implementation of -is-suffix? tries to find the first element of list that matches the first element of suffix and then checks to see if the rest of list matches suffix. However, this means that examples like (-is-suffix? '(a b) '(a c a b)) evaluate to false, which should be a bug. This new implementation fixes the bug.

basil-conto commented 3 years ago

Thanks for catching this, and sorry about this blunder!

I'll cut 2.19.1 as a bugfix release shortly.

basil-conto commented 3 years ago

I'll cut 2.19.1 as a bugfix release shortly.

Done: https://github.com/magnars/dash.el/releases/tag/2.19.1

Should be live on GNU ELPA and GNU-devel ELPA within a few hours.