Relax expected timestamp test to a 48hr range for zipfile entries

magnars / optimus

A Ring middleware for frontend performance optimization.

364 stars 23 forks source link

Relax expected timestamp test to a 48hr range for zipfile entries #13

Closed radhikalism closed 10 years ago

radhikalism commented 10 years ago

The last modified timestamp for zip/jar entries is TZ-lossy and may not serialize/deserialize across timezones to exactly the same unixtime. The unit test is only concerned with finding a plausible timestamp, not a perfectly accurate one. The +24hr/-24hr range is wide enough to cover all timezones.

magnars commented 10 years ago

Excellent. Thank you!