search

magnars / optimus

A Ring middleware for frontend performance optimization.
364 stars 23 forks source link

Fixed optimus.class-path to work under windows environments #55

Closed saeidscorp closed 4 years ago

saeidscorp commented 7 years ago

Hi Magnar! Despite the more fundamental problem with windows (clj-v8), I added a quick fix to provide the ability to use regexes in windows.

I used #52 to get optimus running. which works fine. (but those changes reside in another branch in my repository)

Any thoughts? ;-)

magnars commented 7 years ago

Thanks, this looks like a good idea. :-) Are backslashes not valid characters on other OSes? Do they always mean /?

saeidscorp commented 7 years ago

Hmmm, Not sure, but Linux allows many characters to be part of file names. (including \)

magnars commented 7 years ago

I guess that means this:

(map #(s/replace % "\\" "/"))

isn't safe to do, without a check. Maybe you could check FileSystem.getSeparator() ?

magnars commented 4 years ago

I'm closing this, but feel free to reopen it!