search

magnars / optimus

A Ring middleware for frontend performance optimization.
364 stars 23 forks source link

Fix base-url rel-path not added to images within contents #56

Closed lsnape closed 7 years ago

lsnape commented 7 years ago

Fixes #9

magnars commented 7 years ago

Hi! Thanks for the fix. This looks like an okay solution to the problem.

Would you mind making a separate test for this feature, with some explanation in line with the other tests?

Also, the function new-path could use a name that better pinpoints what it is doing.

lsnape commented 7 years ago

I've made the changes you requested. Let me know if you think anything else is required :)

magnars commented 7 years ago

This looks great, thank you!

magnars commented 7 years ago

0.19.2 released with this fix.

lsnape commented 7 years ago

My pleasure :) and thanks for making a release 👍