magnars / optimus

A Ring middleware for frontend performance optimization.
364 stars 23 forks source link

clean-css upgrade request #63

Open ghost opened 6 years ago

ghost commented 6 years ago

thanks for writing optimus! It would be nice if the clean-css dependency could be upgraded to the latest version, as it contains some bugfixes regarding attribute merging etc.

magnars commented 6 years ago

Thanks for the heads up, @sj4 - that's a good idea. Could you give me one CSS-example for one such bug fix (before and after), so that I can add it to the test suite and verify that I've done the upgrade correctly? 🙂

ghost commented 6 years ago

before upgrade, with clean-css 3.0.7, the following input css

.app-logo {
  background: url('/og.png') no-repeat center;
  background-color: none;
}

will result in

.app-logo{background:url(/og.png) center no-repeat none}

which is wrong.

a later version of clean-css should not merge background-color: none; into background

magnars commented 6 years ago

This turned out more complicated than I had hoped. There are quite a few breaking changes. I'll have to return to this some other day, unfortunately.

ghost commented 6 years ago

no pressure :-)