Closed radhikalism closed 5 years ago
This looks good. It seems like we also need to update the travis script to include proper versions of Java, because the build is failing. Would you be willing to give that a shot as part of this PR?
So to explain the changes to the travis config:
install-jdk.sh
similar to what's noted at https://travis-ci.community/t/install-jdk-sh-failing-for-openjdk9-and-10/3998install-jdk.sh
which is intentionally for the latest and greatest JDKs (though a JDK8 may be preinstalled on xenial
— not using jdk
— but may not survive in later distros)cacerts
is up-to-date for ClojarsI'm not sure if Gravis-CI is going to be entirely reliable, but may be worth a try considering the known-problematic default alternative.
Outstanding. That was above and beyond. Thank you!
On trying to run
lein midje
onmaster
with a JDK newer than JDK8, I encountered a variety of errors. Some were caused bymidje
orlein-midje
being out of date, so this commit bumps those dependencies.Newer JDKs also have millisecond resolution for
getLastModified
, which breaks asset creation tests that rely on the seconds resolution of JDK8 (which is encoded intotest-with-files
too). Rather than switch between resolutions (which I think may be tricky withtest-with-files
) this commit simply truncates the last-modified value to seconds to retain JDK8's behavior and keep tests passing.(Note there may be a race condition edge case where last-modified is a full 1000ms later than
test-with-files
expects, but I'm not sure how to repro this reliably yet or if it's pre-existing intest-with-files
. It can cause intermittent test failures.)Comments?