magne4000 / quassel-webserver

A web server/client for Quassel
MIT License
210 stars 38 forks source link

Properly force default #277

Closed ohnx closed 5 years ago

ohnx commented 5 years ago

Currently, if the client supplies a different host from the one in the settings, the server will accept it anyway and attempt to connect. Maybe this is intended behaviour, but my understanding of "Will force default host and port to be used if true" is that there will be validations server-side to ensure this is true. This PR adds those server-side checks :)

Also, this PR fixes a bug that crashes the server when an error is encountered when connecting to the quassel core. Now instead, the client gets messed up.

Please squash and merge this PR since I made most of them on GitHub and could only edit one file at a time.