search

magneticio / vamp

Vamp - canary releasing and autoscaling for microservice systems
http://vamp.io
Apache License 2.0
624 stars 55 forks source link

inconsistent trailing slash "/" on workflows API endpoint #1026

Closed tnolet closed 7 years ago

tnolet commented 7 years ago

API endpoints generally except calls with or without trailing slash. i.e. these are both valid

 http://localhost/service/vamp/api/v1/deployments/
 http://localhost/service/vamp/api/v1/deployments

However, the workflows and breeds endpoint only accepts calls without a slash.

this is valid

http http://localhost/service/vamp/api/v1/workflows

this is not

Tims-MacBook-Pro:vamp-cli tim$ http http://localhost/service/vamp/api/v1/workflows/
HTTP/1.1 404 Not Found
Connection: keep-alive
Content-Length: 42
Content-Type: text/plain; charset=UTF-8
Date: Wed, 30 Aug 2017 09:57:49 GMT
Server: openresty/1.9.15.1

The requested resource could not be found.
jason-magnetic-io commented 7 years ago

@tnolet can you verify that this is fixed?