magnific0 / nokia-weight-sync

Get weight from Nokia Health and update in Garmin Connect or Smashrun
GNU General Public License v3.0
71 stars 30 forks source link

Water % #11

Open moozphat opened 5 years ago

moozphat commented 5 years ago

There seems to be an issue with synching of water percentage. A reading of 61.4% in Health Mate shows as 46.5% in Garmin Connect. Could this be an encoding or unit issue with the hydration data? The other readings (fat, muscle, etc) are fine.

piccit commented 5 years ago

Withings gives it as mass (in kg, I think) but Garmin expects a percentage - so that's why it's wrong

moozphat commented 5 years ago

Great; that is exactly it and explains the numbers I am seeing... My last reading is 46.8kg water / 76.4kg total weight (61.2%) and shows as 46.8% in GC.

moozphat commented 5 years ago

So, I have fixed on my local copy. Here is the proposed fix which I tried to make elegant...

In fit.py:

In nokia_weight_sync.py:

By the way, thanks for this great project!

rafdev18 commented 5 years ago

How does your Withings scale still sync ? I do have now sync issues as they switched to OAuth 2.0 - Any help is appreciated !

Am 13.01.2019 um 17:29 schrieb moozphat notifications@github.com:

So, I have fixed on my local copy. Here is the proposed fix which I tried to make elegant...

In fit.py:

Line 205: Add an additional argument: water_mass=None

Line 209: Add this code to make the conversion: if water_mass is not None: percent_hydration=water_mass/weight*100

In nokia_weight_sync.py:

Line 363: Replace percent_hydration=m.get_measure(types['hydration']) by water_mass=m.get_measure(types['hydration']) By the way, thanks for this great project!

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/magnific0/nokia-weight-sync/issues/11#issuecomment-453843807, or mute the thread https://github.com/notifications/unsubscribe-auth/AklSBqK0QCuQ5pR0ZLKYEBTLc43D7xQjks5vC17ZgaJpZM4Z81Jr.

moozphat commented 5 years ago

@rafdev18 I just bought this scale and followed the readme instructions. I noted that I could not use localhost and I had to use port 80 or 443 when registering on withings... I would try to redo the whole process and delete config.ini as it worked for me.

Or, I am thinking it might have something to do with your dependencies versions (ie requests-oauthlib). Good luck

magnific0 commented 5 years ago

@moozphat thanks for the reporting this issue, suggested fixes and and activity in this issue. I'll try to implement the code some time in the near future. I'll update here and close the issue once it is done.