search

magnificode / WPMakeOutput

1 stars 1 forks source link

Pulling in things from the component library and from _s. #9

Open saltcod opened 6 years ago

saltcod commented 6 years ago

Though this theme is designed to be bare bones, I'd like to open the discussion about using certain parts of the 10up component library and the _s theme that lots/most of us use for scaffolding.

From _s: archive.php, content.php, index.php, 404.php. All maybes, but wanted to discuss

From component library: logo / sitename markup, content-single.php markup, schema markup, etc

I've been on a few projects where the schema stuff needed to be added in after because we forgot it, as a quick example of why this might be useful. I feel like most projects we work on will need a content-single.php. Including a really good version of that feels like a good thing to me.

timwright12 commented 6 years ago

I would like to use npm for component library items and move to that for all dependency management in the future so we don't have a directory like /assets/js/vendor for plugins. There's a bit of a path to get there though.

magnificode commented 6 years ago

I'm going to mark this as an enhancement and assign it to you @timwright12 since you'll likely spearhead the effort to get the component library modularized into NPM.

Happy to pass the buck over to someone else if that assumption is incorrect.

timwright12 commented 6 years ago

Correct assumption, we'll try and get an internal project moving to convert the component library. I imagine wpmake will be complete before the conversion is ready, so let's plan for that as well.