search

magnifydev / magnify

A Digital Program of Studies for LMHS.
https://magnify.web.app
Apache License 2.0
8 stars 0 forks source link

Course editing is buggy #28

Open Ascent817 opened 2 years ago

Ascent817 commented 2 years ago
  1. It's possible to delete the field headings: image
  2. When cancel is clicked the contents of the card do not revert until reload.
GoogolGenius commented 2 years ago

@Ascent817 The contents of the card don't change back because we completely mess up React's handling of the DOM. Honestly, we should revamp this with the modal/form you suggested earlier.

Ascent817 commented 2 years ago

I agree. I'm leaning towards a modal, especially since you already implemented one. What do you think?

GoogolGenius commented 2 years ago

It's a good idea. We really should refactor things so they're more reusable (dynamic components, better CSS, etc.). I often copy and paste code from other elements to have the same style.

GoogolGenius commented 2 years ago

Btw, we need to be able to store login info longer term, I find it annoying that it completely resets and we have to login again after a page reload.

Ascent817 commented 2 years ago

Store with cookies?

GoogolGenius commented 2 years ago

I think so. Then we need cookie warning lol :)

Ascent817 commented 2 years ago

We would be the only people getting cookies lol

GoogolGenius commented 2 years ago

I feel like we should rerender the DOM after clicking Cancel, though that would be a performance hit hmm. It's better as a modal.

GoogolGenius commented 9 months ago

This likely needs to be fixed for teachers/admin