search

magnopus-opensource / connected-spaces-platform

"An interoperable communication library for the spatial internet."
https://www.magnopus.com/csp
Apache License 2.0
89 stars 12 forks source link

CinematicCameraSpaceComponent in CSP 5.2.0+536 IsEnabled() functions missing override in declaration #504

Closed kevinmagnopus closed 3 weeks ago

kevinmagnopus commented 1 month ago

Describe the bug

CinematicCameraSpaceComponent in CSP 5.2.0+536 IsEnabled() functions missing override in declaration

To Reproduce

Steps to reproduce the behavior:

  1. Download the CSP release
  2. Build an application that uses the CinematicCameraSpaceComponent
  3. Notice the compiler warnings:

./include/CSP/Multiplayer/Components/CinematicCameraSpaceComponent.h:173:7: warning: 'GetIsEnabled' overrides a member function but is not marked 'override' [-Winconsistent-missing-override] bool GetIsEnabled() const; ^ ./include/CSP/Multiplayer/Components/Interfaces/IEnableableComponent.h:33:15: note: overridden virtual function is here virtual bool GetIsEnabled() const = 0; ^ In file included from components_getset.cpp:28: ./include/CSP/Multiplayer/Components/CinematicCameraSpaceComponent.h:175:7: warning: 'SetIsEnabled' overrides a member function but is not marked 'override' [-Winconsistent-missing-override] void SetIsEnabled(bool InValue); ^ ./include/CSP/Multiplayer/Components/Interfaces/IEnableableComponent.h:37:15: note: overridden virtual function is here virtual void SetIsEnabled(bool InValue) = 0; ^

Expected behaviour

No compiler warnings (IsEnabled() functions are properly decorated)

CSP version (please complete the following information):

release 5.2.0+536

Language:

C++

Desktop (please complete the following information):

MacOS on Apple silicon

MAG-SamBirley commented 1 month ago

Thanks for reporting this! We intend to get someone to take a look at this over the next couple weeks.

MAG-SamBirley commented 3 weeks ago

This issue has now been resolved in develop. Thanks for raising it!