magnus-ISU / inventorytabs

Adds tabs to access nearby blocks
MIT License
0 stars 0 forks source link

Feature request: Named inventories show their names #4

Open magnus-ISU opened 2 years ago

magnus-ISU commented 2 years ago

First character over the chest icon, and the whole name when hovering over it.

This may not be feasible to implement on the client, I'm unsure.

Andrew6rant commented 2 years ago

It is possible to implement on the client, LiamMCW's fork for version 1.17.1 of this mod actually had that feature. (I'd just temporarily removed it to make porting to 1.18.x easier)

image

I believe the relevant code for this is under SimpleBlockTab.java, but it has been a bit since I've worked on this project. I know for certain that my accesswidener is not proper code, haha

EDIT: Oh my gosh, I completely forgot that I did re-implement this feature (with the acesswidener). It wouldn't be too difficult to make the first character of the name show up all the time, sine the data is already there

magnus-ISU commented 2 years ago

Interesting. I'm pretty sure I was noticing this not happening on the server I play on, but I did see some code relating to it. I'll look at it further later. Right now I'm working on #3