magnus-ISU / videospeed

HTML5 video speed controller (for Firefox). WebExtensions port of Video Speed Controller Chrome extension.
24 stars 3 forks source link

Shift+wheel is occupied by the extension even for disabled websites? #28

Open chausies opened 8 months ago

chausies commented 8 months ago

I have "youtube.com" on the list of sites where the extension should be disabled. However, even so, the shift+wheel shortcut seems to be "occupied" by the extension.

In particular, I use a simple userscript (via ViolentMonkey) that makes it so I can seek through a Youtube video with shift+wheel. But that script simply doesn't work when your extension is enabled, even though youtube.com is on the disabled site list. When I disable your extension, my userscript goes back to working. Furthermore, when I enable your script and check "Disable Shift+Scroll to change speed", then my script still works. But if shift+scroll is enabled and youtube.com is on the blacklist, the shift+scroll shortcut seems to be occupied, not allowing my userscript to work.

Any way you can properly let go of the "script+scroll" shortcut on blacklisted websites?

chausies commented 7 months ago

As an imperfect workaround, I can disable permissions for the extension to "access your data for all websites". That disables the extension by default for all websites (including youtube), so my userscripts aren't obstructed. Then, if I want to enable the extension at any time, I just click the extension in the toolbar, and that grants permission. Adds an extra click (which is annoying), but yeah, it works better than having to manually disable the extension every time I want my youtube userscript to work.