magnusbaeck / logstash-filter-verifier

Apache License 2.0
191 stars 27 forks source link

Add daemon mode continue (WIP) #106

Closed breml closed 3 years ago

breml commented 3 years ago

@magnusbaeck I continued to work on the daemon mode. There are still quite some issues to be resolved and features to be added. Feel free to have a look. If you do review this, give me a shout, such that I can continue on a different branch with the further development.

The most interesting features, that have been added are:

Additionally some bug fixing and small improvements here and there.

I also updated the checklist in https://github.com/magnusbaeck/logstash-filter-verifier/issues/96#issuecomment-797559730

magnusbaeck commented 3 years ago

Starting to look at this now. Should I go ahead and push commits that look fine into master as I go along? Will obviously only work until I have comments for a commit, but still.

breml commented 3 years ago

As you like. I forked a new branch for my current work. If you have comments, I will decide if I fix them on the PR or on my new branch depending on complexity and effort. When ever this PR is merged, I will rebase my new branch on master before creating a new PR.

breml commented 3 years ago

@magnusbaeck I addressed your review feedback and updated the PR.