Add support for value of object type

magnusbaeck / logstash-filter-verifier

Apache License 2.0

192 stars 27 forks source link

Add support for value of object type #13

Closed breml closed 7 years ago

breml commented 7 years ago

Nested fields (values of object type) are addressed in Logstash with field reference notation (1). The nested field names are put into square brackets [], starting on the top level. If a top level field is addressed, the square brackets might be omited.

Currently values of object type are not allowed in arrays.

Fixes #12

magnusbaeck commented 7 years ago

Thank you, looks great! If you could just amend your commit with the following small adjustments:

The documentation of the fields key in the Test case file reference section in README.md needs to be updated.
The comment preceding IsValid() in logstash/fieldset.go shouldn't state that objects aren't supported.

(On a related note I'm going to implement support for ignoring subfields via ignore.)

breml commented 7 years ago

@magnusbaeck updated my PR based on your feedback.

magnusbaeck commented 7 years ago

Thanks again! Merged.