search

magnusbaeck / logstash-filter-verifier

Apache License 2.0
191 stars 27 forks source link

Fix automatic IDs #135

Closed breml closed 2 years ago

breml commented 2 years ago

Automatically adding the IDs did not work before, because during the creation of the ZIP file, that is passed to the daemon, the Logstash config files have been read from disk again. With this, the original config has been passed along, which does not contain the required IDs.

To prevent this, the validation step for the Logstash config is now part of the creation of the ZIP file.

Fixes: #131

breml commented 2 years ago

@magnusbaeck I rebased this PR to make it mergable. As a drive by, I updated the dependency to github.com/breml/logstash-config to fix #141 .

Caused by the updated dependencies I had to raise the Go version for the test execution as well.

magnusbaeck commented 2 years ago

Would you mind also patching in the new Go version in go.mod and in the makefile? Otherwise I suppose we'd get a build error when attempting to build release binaries.

breml commented 2 years ago

Sure thing. Instead of rushing for 1.17.x, I decided to update everything to use the latest 1.16.x version. Especially I updated the README, because due to the updated dependencies, it was no longer true, that 1.13 is enough to build this project. I hope this is fine. If you wish to update everything to 1.17.x I can do this as well, no problem.