JSON unmarshal does not produce ints - Githubissues

magnusbaeck / logstash-filter-verifier

Apache License 2.0

192 stars 27 forks source link

JSON unmarshal does not produce ints #20

Closed breml closed 7 years ago

breml commented 7 years ago

Strictly speaking, JSON unmarshal does not produce ints but only float64. therefore, the following lines of code are not used:

https://github.com/magnusbaeck/logstash-filter-verifier/blob/master/logstash/fieldset.go#L54-L55
https://github.com/magnusbaeck/logstash-filter-verifier/blob/master/logstash/fieldset_test.go#L72-L79 (maybe the testcase should be changed to an float without decimal, respectively with a decimal part of 0)

Should we remove this code section?

magnusbaeck commented 7 years ago

Yes, why not? Dead code is wasteful and confusing.