magnusbaeck / logstash-filter-verifier

Apache License 2.0
192 stars 27 forks source link

Change timeout when use --sockets #32

Closed disaster37 closed 7 years ago

disaster37 commented 7 years ago

I have lot of rules and logstash take some time to start. So I get timeout when use --sockets. There are a way to change this timeout ?

breml commented 7 years ago

Currently there is no option/flag to modify the timeout. This constant is used https://github.com/magnusbaeck/logstash-filter-verifier/blob/master/logstash-filter-verifier.go#L122. But it would not be that much a problem to add a flag for this timeout.

That being said, it really surprises me, that the 60 seconds timeout does not work for you, because my observation is, that Logstash normally needs ~15 seconds to start. The actual processing of the testcases normally only takes very little time (except you use very slow filters in Logstash like lookups to other systems). Could you provide some more details about your use case and how may testcases you are talking about?

matejzero commented 7 years ago

In my case, logstash takes close to 1m to start (running time logstash-filter-verifier reports a little under 60s).

I do have a lot of patterns and configuration files.

breml commented 7 years ago

Created PR #33 to resolve this issue.

disaster37 commented 7 years ago

Thanks a lot ;)

matejzero commented 7 years ago

Thanks Breml, you are the best:)