search

magnusbaeck / logstash-filter-verifier

Apache License 2.0
192 stars 27 forks source link

Add describe / description on testcases #36

Closed disaster37 closed 7 years ago

disaster37 commented 7 years ago

Add the ability to add filed called describe or description in testcases to print it on output. For exemple, replace 

Comparing message 2 of 1_10_beeware_test.json...

by 

Comparing message 2 of 1_10_beeware_test.json ($describe)...
matejzero commented 7 years ago

I must say I would benefit from this as well. Since JSON doesn't support comments, I sometimes have difficulties figuring out the differences between tests.

In some tests, I only have one or two char that are different and it's hard to spot them or better yet, to know why I test this difference.

disaster37 commented 7 years ago

Hey, at the moment you can just add filed name "describe" on each testcases. It's work without problem, but this field is not use for stdout the result.

magnusbaeck commented 7 years ago

Yes, this was brought up by @breml in #21 and I think it's a great idea.

matejzero commented 7 years ago

Oh well, did not think of that:) I guess I'm all set then, but it would make it easier to debug, if it would be printed on the output as well.

breml commented 7 years ago

As @magnusbaeck already mentioned, I also thought about this feature. It should not be that hard to implement (maybe I find some time to implement this).