search

magnusbaeck / logstash-filter-verifier

Apache License 2.0
192 stars 27 forks source link

Add description for test cases #37

Closed breml closed 7 years ago

breml commented 7 years ago

The output Comparing message 2 of 1_10_beeware_test.json... is printed while iterating over all received events in line testcase/testcase.go#L189. At this point, a check to verify, if the number of received events equals the number of expected events, was already performed here. Because of this behavior and because it is possible, that an input line may generate no events, an event per input or event multiple events for a single input, the number of descriptions has to match the number of expected events. This makes the implementation a little bit awkward.

I am open for suggestions to improve the solution.

Fixes #36

magnusbaeck commented 7 years ago

A bit awkward as you say, but I don't have any suggestions for making it cleaner so let's go with this for now. Thanks!

matejzero commented 7 years ago

Thank you very much Breml. Love all the commits you've pushed to this app.

breml commented 7 years ago

@matejzero My pleasure!