search

magnusbaeck / logstash-filter-verifier

Apache License 2.0
192 stars 27 forks source link

fix keep-env: allow keeping multiple env vars #55

Closed arielstolerman closed 6 years ago

arielstolerman commented 6 years ago

The 'break' call in setting up the environment variables prevented multiple env vars from being kept with multiple --keep-env arguments. Removing it solves the problem.

magnusbaeck commented 6 years ago

Thanks! But the second commit that adjusts the import statements wasn't meant to be part of this PR, was it?

arielstolerman commented 6 years ago

@magnusbaeck indeed, the second commit was in order to make it work locally without waiting for the PR to be accepted; didn't realize subsequent commits after the PR is submitted will also be included. Reverted changes, PTAL. Thanks for this project btw!

magnusbaeck commented 6 years ago

Thank you! Sorry for the delayed merge.