Add YAML support and dot notation for fields, exclude and input

magnusbaeck / logstash-filter-verifier

Apache License 2.0

192 stars 27 forks source link

Add YAML support and dot notation for fields, exclude and input #70

Closed disaster37 closed 4 years ago

disaster37 commented 4 years ago

Add some enhances:

Add test case YAML support and keep JSON support
Add dot notation in exclude fields to excludes sub fields like log.file.path
Add dot notation in fields to write test in easy way: "log.file.path": "/tmp/test.log" is equivalent to "log": {"file": {"path": "/tmp/test.log"}}.
Add dot notation in input when use json_lines codecs to write test in easy way: {"log.file.path": "/tmp/test.log"} is equivalent to {"log": {"file": {"path": "/tmp/test.log"}}}.

I add some unit test and fix readme.

magnusbaeck commented 4 years ago

Thanks for the PR, and sorry for the slow response. I glanced through the patch and it looked reasonably okay. I hope I can review it thoroughly during the coming week.

disaster37 commented 4 years ago

Any news ? There are still somethink I need to fix ?

magnusbaeck commented 4 years ago

Sorry, I've just been swamped with other things. I'll get to it. (Note that your branch conflicts with master, so in the meantime you can resolve that.)

langoureaux-s commented 4 years ago

I am so sorry, but how I can found the conflict in testcase/testcase.go?

magnusbaeck commented 4 years ago

I am so sorry, but how I can found the conflict in testcase/testcase.go?

@langoureaux-s, I'm not sure what you mean. If you merge the PR branch with the master branch I'd expect you to get a merge conflict in testcase/testcase.go. The conflicting lines will be visible with the usual conflict markers inside the file.

magnusbaeck commented 4 years ago

Thanks! I'll push a follow-up commit to fix up typos and a few minor things. When I have time I'll push another commit that removes the dot notation support since it, as I said, is ambiguous. People should be able to have fields with dots in the names without getting into trouble with LFV.

matejzero commented 4 years ago

YAML support is really nice and a great addition to LFV. Is it possible to cut a release with this new feature so I can add it to our CI pipeline?

Thanks.

magnusbaeck commented 4 years ago

Once the follow-up PR (#72) has been merged I'll make a release as soon as I can.

magnusbaeck commented 4 years ago

Once the follow-up PR (#72) has been merged I'll make a release as soon as I can.

1.6.0 is available now.