search

magnusja / libaums

Open source library to access USB Mass Storage devices on Android without rooting your device
Apache License 2.0
1.26k stars 270 forks source link

Fix/298 #374

Closed magnusja closed 1 year ago

magnusja commented 1 year ago

Should be the same as https://github.com/tracmap/libaums/commit/7b9219106419142dec6b1a179067037a9e73c18d. But without creating a temporary buffer.

Screenshot 2023-03-10 at 14 15 31

Specifically we want to avoid calling clear here and instead use the position the buffer is that currently.

Addresses

codecov[bot] commented 1 year ago

Codecov Report

Merging #374 (1a13466) into develop (bd312ab) will increase coverage by 0.03%. The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             develop     #374      +/-   ##
=============================================
+ Coverage      56.52%   56.56%   +0.03%     
  Complexity       366      366              
=============================================
  Files             48       48              
  Lines           1769     1768       -1     
  Branches         244      244              
=============================================
  Hits            1000     1000              
+ Misses           696      695       -1     
  Partials          73       73
Impacted Files Coverage Δ
...jahnen/libaums/core/driver/scsi/ScsiBlockDevice.kt 0.00% <0.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more