magnusmanske / petscan_rs

The repo for the PetScan tool
https://petscan.wmflabs.org/
GNU General Public License v3.0
45 stars 10 forks source link

Fix #137 by removing needless deXSS function #138

Closed mwootten closed 10 months ago

mwootten commented 1 year ago

The deXSS function escapes text so that it's safe to insert as raw HTML. However, its output gets passed into .val() and .text(), which directly manipulate the DOM and so don't require or support escaping; thus, the escaping breaks the queries. Remove deXSS where superfluous and replace its one non-superfluous use with safe DOM manipulation.