search

magpie-ea / magpie-modules

the reusable front-end bits in the _magpie modules
MIT License
7 stars 1 forks source link

Use ESLint #34

Open x-ji opened 5 years ago

x-ji commented 5 years ago

We should really clean up the frontend code with a uniform standard such as ESLint. Currently ESLint reports errors all over the place.

@JannisBush I'm not sure what editor/IDE you use. Maybe you could integrate ESLint with the editor, see the errors reported (of course one can also run ESLint in the command line), and decide on a code standard. After that we should eliminate ESLint errors as much as possible on the frontend (the errors about not using module imports might be hard to deal with, but others such as those about coding style should be doable).

This also applies to the other frontend repos out there.

JannisBush commented 5 years ago

The errors about import are probably hard to get rid of without a major restructuring of the front-end as mentioned in #21. But I also had the problem that style errors are reported everywhere and will try to fix most of them and decide on a code standard.