search

magpie-ea / magpie-modules

the reusable front-end bits in the _magpie modules
MIT License
7 stars 1 forks source link

SPR fails if you press another button #59

Closed JannisBush closed 5 years ago

JannisBush commented 5 years ago

The spr views fail, if you press a key other than the space bar.

JannisBush commented 5 years ago

https://github.com/babe-project/babe-project/blob/master/src/babe-views.js#L1086

Apparently, this is the wanted behavior? I assume that a lot of people might accidentally press a key like b instead of the space bar every N trials (happened to me for example). Therefore we should change this behavior, because currently you are then stuck and can't do anything anymore. But what do we want to do if an incorrect button was pressed?

What is your opinion on this?

x-ji commented 5 years ago

That doesn't seem to make much sense. IMO the mispress should just be ignored?

x-ji commented 5 years ago

Though I'm not sure if there's something specific about the recorded reaction time to be considered in such experiments.

michael-franke commented 5 years ago

Ignoring would be just fine.

On Apr 25, 2019, at 17:44, Xiang Ji notifications@github.com wrote:

Though I'm not sure if there's something specific about the recorded data in such experiments.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.