search

magr0s / vue-scrollmagic

Vue.js plugin
MIT License
72 stars 24 forks source link

TypeScript support #5

Open JakubKoralewski opened 5 years ago

JakubKoralewski commented 5 years ago

Do you think you could add support for TypeScript?

In its current form (1.1.1) in VSCode Vetur throws this error when trying to access this.$scrollmagic:

Property '$scrollmagic' does not exist on type 'Index'.

Even though when I console.log(this.$scrollmagic) everything is fine. I'd really appreciate ts definitions.

JakubKoralewski commented 5 years ago

Maybe something like this:

https://gist.github.com/JakubKoralewski/ffe787c10676d1667eb0f962fff1c43b

JakubKoralewski commented 5 years ago

I've added descriptions and fixed some types in functions. Added handleScrollTo,