search

magro / kryo-serializers

More kryo serializers
Apache License 2.0
381 stars 120 forks source link

Add copy functionality to Guava multimaps #101

Closed f4lco closed 5 years ago

f4lco commented 5 years ago

This should add Kryo#copy for Guava Multimaps.

The first commit fixes the multimap comparison in unit tests. I discovered that I could not make the test red for ordered keys, e.g., when creating a copy without the comparators of the original, because the underlying equality test was still "set logic equals".

coveralls commented 5 years ago

Coverage Status

Coverage increased (+0.2%) to 86.264% when pulling f209a3fc465e156d7912507958fc21a6ba487879 on f4lco:guava-multimap-copy into e8cea98bda12b13b81ef7eac1a33f1753adf698e on magro:master.

magro commented 5 years ago

Thanks for the PR!

f4lco commented 5 years ago

You're welcome, @magro. Thanks for maintaining this very useful project 👍