protobuf 3 support with backwards compatibility

magro / kryo-serializers

More kryo serializers

Apache License 2.0

381 stars 120 forks source link

protobuf 3 support with backwards compatibility #103

Closed clatko closed 5 years ago

clatko commented 5 years ago

change the protobuf version in the pom from 2.6.1 to 3.0.0 and the tests will still pass.

coveralls commented 5 years ago

Coverage decreased (-0.1%) to 86.276% when pulling 5537bc8d021872e5c61325c577b1c6957de2893c on clatko:master into b11df0d443bbe44d06c84f54c57e777d0cf66b96 on magro:master.

coveralls commented 5 years ago

Coverage decreased (-0.1%) to 86.276% when pulling 5537bc8d021872e5c61325c577b1c6957de2893c on clatko:master into b11df0d443bbe44d06c84f54c57e777d0cf66b96 on magro:master.

magro commented 5 years ago

@clatko Thanks for the PR! Can you please elaborate a bit more the motivation for this?

clatko commented 5 years ago

This wil support protobuf 2 and 3. Just change the version in Pom.xml from 2.6.1 to 3.0.0 and all will work. Change back to 2.6.1 and it will still work. I didn’t have time to figure out how to test both versions simultaneously using the respective protobuf library versions.

magro commented 5 years ago

Let me rephrase my question: what does currently not work what is fixed with this PR? And what is different to the recently merged PR #93? TBH, I don't understand why github shows a diff at all. Maybe you should rebase against the current master?

clatko commented 5 years ago

It is actually the same thing. Hah. I'll close this one.

magro commented 5 years ago

Ok, thanks anyways :-)