Open wyhasany opened 3 years ago
Any progress with unmodifable collection support for Kryo5?
Kryo 5 can be used without problems. The Readme just doesn't reflect that.
Could you add an example on how to do that exactly? We ended up reimplementing all the unmodifable collection serializers for Kryo 5.
@paplorinc: What kind of issue did you have? I'm using Kryo 5 and simply call:
UnmodifiableCollectionsSerializer.registerSerializers(kryo);
SynchronizedCollectionsSerializer.registerSerializers(kryo);
The latest version of this project already depends on an old Kryo 5 RC so this works fine for me.
@magro: Any chance you could bump the Kryo dependency to the latest release and update the readme?
We depend on both version of Kryo, so we're getting:
OK, that's bad. I guess this wasn't taken into account when the separate Kryo 5 artifact was created. This will be tough to fix.
Since unmodifable collections are part of the JDK, we could add built-in support for them to Kryo. Some of the serializers where already moved over to Kryo in the past. I don't know why these weren't included.
It seems that has been discussed a couple of times in the past:
Nate was against including any "unsafe" serializers, i.e. serializers depending on internal state of the objects not available through public APIs.
Are there any updates on this?
I hope this is done soon! thanks!
Do you plan to support Kryo v5? Main readme says that you support only v2, v3, v4 versions. Is it very hard to implement v5 support?