search

magro / kryo-serializers

More kryo serializers
Apache License 2.0
381 stars 120 forks source link

UnicodeBlockSerializer #70

Closed Pr0methean closed 7 years ago

Pr0methean commented 7 years ago

New serializer for Character.UnicodeBlock, with test. Takes into account that this class is effectively an enum.

ghost commented 7 years ago

@Pr0methean Thanks for the contribution. Perhaps next time you could do this work on a local branch, and once everything is working, squash, push, and pull request. The email spam for every one of these commits for all 31 watchers of this repository isn't very polite, thanks! 😉

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.05%) to 85.333% when pulling 54272a51d442b2fbf33af2ff8478dd31c3805818 on Pr0methean:master into d34f6f0eaca693c5ef3c0daa436b666b5679d9d9 on magro:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.05%) to 85.333% when pulling 54272a51d442b2fbf33af2ff8478dd31c3805818 on Pr0methean:master into d34f6f0eaca693c5ef3c0daa436b666b5679d9d9 on magro:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.05%) to 85.333% when pulling 54272a51d442b2fbf33af2ff8478dd31c3805818 on Pr0methean:master into d34f6f0eaca693c5ef3c0daa436b666b5679d9d9 on magro:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.08%) to 85.359% when pulling 8f74c327ac26a6958473c2ed82afb3bdbe835647 on Pr0methean:master into d34f6f0eaca693c5ef3c0daa436b666b5679d9d9 on magro:master.

Pr0methean commented 7 years ago

@3xp0n3nt Will do. Sorry, I didn't see your comment until after I'd finished, and I didn't realize I'd left the PR open after the tests had failed.

ghost commented 7 years ago

@Pr0methean No problem. 😺

magro commented 7 years ago

@Pr0methean thanks for the PR! I don't see any reason why this shouldn't go directly into kryo, as it's part of the jdk and not jvm/vendor specific. Can you please submit the PR against kryo?

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.08%) to 85.359% when pulling 4098a9085132ec1f8972e9eab5d002c29a0fb025 on Pr0methean:master into d34f6f0eaca693c5ef3c0daa436b666b5679d9d9 on magro:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.08%) to 85.359% when pulling 0a310248163e56afa77a702ef7b4c03fae3e44f4 on Pr0methean:master into d34f6f0eaca693c5ef3c0daa436b666b5679d9d9 on magro:master.

Pr0methean commented 7 years ago

The update to the README is https://github.com/magro/kryo-serializers/pull/70/files#diff-0a369498a5a8db3ac8fa606b544c9810. The debug code is removed from the test in https://github.com/magro/kryo-serializers/pull/70/files#diff-328d875a27bcefdefd6a0d692c6b7d66

magro commented 7 years ago

Thanks!