search

magro / kryo-serializers

More kryo serializers
Apache License 2.0
381 stars 120 forks source link

Upgrade to google-protobuf 3.6.1 to support proto3 messages #93

Closed mohamabid closed 5 years ago

mohamabid commented 6 years ago

Hi, Wanted to continue using the library to serialize our proto3 messages. Change Should continue to support proto2 messages.

Let me know if you want me to make any changes or discuss. Open to making more contributions.

Thanks, Abid

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.02%) to 86.059% when pulling 0dcc9757cac6f06641dc541331124b42e122d240 on mohamabid:master into 57e38d08754ab2ec247b06b9e20fc2ef88676218 on magro:master.

mohamabid commented 6 years ago

@magro can you take a look when you get a chance. Thanks.

magro commented 5 years ago

@mohamabid what happens to users of protobuf-java 2.x?

mohamabid commented 5 years ago

@magro As we now expect messages to extend com.google.protobuf.AbstractMessage which was present in protobuf-Java 2.x, this change should not affect users of 2.x

magro commented 5 years ago

Great, sounds good then!

mohamabid commented 5 years ago

@magro Thanks!