search

magro / memcached-session-manager

A tomcat session manager that backups sessions in memcached and pulls them from there if asked for unknown sessions
Apache License 2.0
760 stars 348 forks source link

Use same logging system as Tomcat #79

Closed ghost closed 9 years ago

ghost commented 9 years ago

From olli.nev...@gmail.com on February 16, 2010 02:55:25

What steps will reproduce the problem?

  1. Use memcached-session-manager with an application that uses Log4j. What is the expected output? What do you see instead? Log messages should be handled by the configured logging system, but they are instead written to System.err stream. What version of the product are you using? On what operating system? 1.1 Please provide any additional information below. Tomcat uses commons logging (http://commons.apache.org/logging/) internally which allows it to be used easily with different logging systems. Unfortunately memcached-session-manager is hard coded to use Java Logging, which causes some pain when the rest of the application is using other logging mechanisms. P.S. Thank you for this great piece of software. We are planning to use it in our web application, which is running on a cluster of four highly loaded web servers.

Original issue: http://code.google.com/p/memcached-session-manager/issues/detail?id=35

ghost commented 9 years ago

From olli.nev...@gmail.com on February 15, 2010 18:14:54

It seems that Tomcat 6.x actually uses org.apache.juli.logging package for logging internally. I think it would make sense to use the same logging in memcached-session-manager.

ghost commented 9 years ago

From martin.grotzke on February 16, 2010 06:50:33

Agreed, it would be better to use juli for logging, I'll change this.

Status: Accepted
Owner: martin.grotzke

ghost commented 9 years ago

From martin.grotzke on February 16, 2010 14:07:03

Changed logging from java.util.logging to org.apache.juli.logging, also added a checkstyle rule for this.

Changes are done in the develop branch, this will be released with 1.2

@-Olli: You might want to subscribe to the mailing list to get notified when 1.2 is released: http://groups.google.com/group/memcached-session-manager If you want to build msm by yourself and you have questions regarding buildr just let me know.

Status: Fixed
Labels: Milestone-1.2