search

magro / testrepo

foo
0 stars 0 forks source link

Add possibility to disable msm at runtime #60

Closed magro closed 9 years ago

magro commented 9 years ago

From martin.grotzke on September 04, 2010 22:07:58

It should be possible to disable msm at runtime, e.g. via jmx.

Original issue: http://code.google.com/p/memcached-session-manager/issues/detail?id=60

magro commented 9 years ago

From martin.grotzke on September 04, 2010 13:57:54

Implemented. There's a new "enabled" property that can be set in the manager configuration, it's also accessible via jxm.

In disabled mode, sessions are not looked up in memcached and not stored in memcached, the SessionTrackerValue is just passing requests to the next valve (for prócessing the request) without doing anything further.

Status: Fixed

magro commented 9 years ago

From pgweiss....@gmail.com on October 21, 2010 07:55:51

This broke a test. Here is a patch.

Attachment: broken-test.patch

magro commented 9 years ago

From pgweiss....@gmail.com on October 21, 2010 08:03:37

When starting disabled by setting <Manager ... enabled="false" .. /> it still creates a memcached client. This causes annoying logging when the server is unavailable. I suggest that the client only be run when enabled=true. This patch suppresses client creation when enabled=false at startup. ( Ideally the client should be brought up or down depending on the state of the enabled flag. )

Attachment: noclient.patch

magro commented 9 years ago

From martin.grotzke on October 21, 2010 15:38:17

Thanx, patches applied. The memcached client now is also created/destroyed when the msm enabled status is changed at runtime (via jmx). Also added tests.

magro commented 9 years ago

From martin.grotzke on January 27, 2011 14:36:22

(No comment was entered for this change.)

Labels: Milestone-1.4.0