magtimmermans / com.cyclone-software.sunevents

First Beta Release
6 stars 9 forks source link

Azimut vs. Azimuth #50

Closed PeterKawa closed 2 years ago

PeterKawa commented 2 years ago

Hi Marcel. Thanks for the great app. v.0.8.2 The (same) variable has different names somehow. It doesn't seem to be a problem, but what's the thought behind it? Testflow: Screenshot_20210907-193624_Homey

Tags: Screenshot_20210907-185627_Homey

Notification: Screenshot_20210907-195015_Homey

Cheers, Peter

magtimmermans commented 2 years ago

Hi,

Mmh, are those both comming from my app?

Not seen this before 😃

Marcel Timmermans Send from my iphone

Op 7 sep. 2021 om 20:10 heeft PeterKawa @.***> het volgende geschreven:



Hi Marcel. Thanks for the great app. v.0.8.2 The (same) variable has different names somehow. It doesn't seem to be a problem, but what's the thought behind it? Testflow: [Screenshot_20210907-193624_Homey]https://user-images.githubusercontent.com/74005072/132390692-ce5a3b13-3afd-4ff9-8ed9-fba9b2b26053.jpg

Notification: [Screenshot_20210907-195015_Homey]https://user-images.githubusercontent.com/74005072/132390741-b43bcdd8-ecb5-40e0-8ad0-2aabd9948eb6.jpg

Cheers, Peter

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/magtimmermans/com.cyclone-software.sunevents/issues/50, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AEI6JEA7YLEWIMC2OWOK5HTUAZIKXANCNFSM5DS5I5OA.

PeterKawa commented 2 years ago

Yes they are indeed. I was helping Martijn with testing the "Flow Checker" app. It also checks for variables. He noticed the different names for one variable inside your app, or something like that ;-)

It was a pure coincidence by the way. 2 flows with the Azimuth change as trigger reported a false positive. Which means, nothing wrong, but the flow checker app decided it was. ;-)

Op di 7 sep. 2021 20:40 schreef magtimmermans @.***>:

Hi,

Mmh, are those both comming from my app?

Not seen this before 😃

Marcel Timmermans Send from my iphone

Op 7 sep. 2021 om 20:10 heeft PeterKawa @.***> het volgende geschreven:



Hi Marcel. Thanks for the great app. v.0.8.2 The (same) variable has different names somehow. It doesn't seem to be a problem, but what's the thought behind it? Testflow: [Screenshot_20210907-193624_Homey]< https://user-images.githubusercontent.com/74005072/132390692-ce5a3b13-3afd-4ff9-8ed9-fba9b2b26053.jpg>

Notification: [Screenshot_20210907-195015_Homey]< https://user-images.githubusercontent.com/74005072/132390741-b43bcdd8-ecb5-40e0-8ad0-2aabd9948eb6.jpg>

Cheers, Peter

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub< https://github.com/magtimmermans/com.cyclone-software.sunevents/issues/50>, or unsubscribe< https://github.com/notifications/unsubscribe-auth/AEI6JEA7YLEWIMC2OWOK5HTUAZIKXANCNFSM5DS5I5OA>.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/magtimmermans/com.cyclone-software.sunevents/issues/50#issuecomment-914537260, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARUTUUGCNHKEGMPPZN7I3MTUAZMDDANCNFSM5DS5I5OA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

magtimmermans commented 2 years ago

Hi,

OK, I will check in the weekend.

Marcel Timmermans Send from my iphone

Op 7 sep. 2021 om 22:12 heeft PeterKawa @.***> het volgende geschreven:



Yes they are indeed.

Op di 7 sep. 2021 20:40 schreef magtimmermans @.***>:

Hi,

Mmh, are those both comming from my app?

Not seen this before 😃

Marcel Timmermans Send from my iphone

Op 7 sep. 2021 om 20:10 heeft PeterKawa @.***> het volgende geschreven:



Hi Marcel. Thanks for the great app. v.0.8.2 The (same) variable has different names somehow. It doesn't seem to be a problem, but what's the thought behind it? Testflow: [Screenshot_20210907-193624_Homey]< https://user-images.githubusercontent.com/74005072/132390692-ce5a3b13-3afd-4ff9-8ed9-fba9b2b26053.jpg>

Notification: [Screenshot_20210907-195015_Homey]< https://user-images.githubusercontent.com/74005072/132390741-b43bcdd8-ecb5-40e0-8ad0-2aabd9948eb6.jpg>

Cheers, Peter

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub< https://github.com/magtimmermans/com.cyclone-software.sunevents/issues/50>, or unsubscribe< https://github.com/notifications/unsubscribe-auth/AEI6JEA7YLEWIMC2OWOK5HTUAZIKXANCNFSM5DS5I5OA>.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/magtimmermans/com.cyclone-software.sunevents/issues/50#issuecomment-914537260, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARUTUUGCNHKEGMPPZN7I3MTUAZMDDANCNFSM5DS5I5OA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/magtimmermans/com.cyclone-software.sunevents/issues/50#issuecomment-914592376, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AEI6JEHC6V2LLKCZCBEVVP3UAZWZXANCNFSM5DS5I5OA.

magtimmermans commented 2 years ago

Hi, I checked this. The first one is the locale argument for the trigger. The value is passed when the trigger is active and you will get the current trigger value (which is the same as the second app Azimut value).