search

magtimmermans / home-assistant-sensor-luchtmeetnet

MIT License
1 stars 4 forks source link

Update making the integration work again #3

Closed bouwew closed 2 years ago

bouwew commented 2 years ago

I've completed the contents of manifest.json, after this the integration is recognized by HA Core 2021.11 I've also made some improvements in the sensor code.

bouwew commented 2 years ago

@magtimmermans You were a little quick approving my PR :) I had left it in draft state because I wasn't sure everything was entirely correct. Anyway, doesn't matter too much as the integration is working (again).

A suggestion: create releases with a version number, the same number as is in the manifest file / version file. Then that version nr will show up in HACS as well, including the release information. That's a good way to communicate to the interested users what is in the update (bugfix, feature added, etc.).

What is your intention with this integration? Are you planning to add more sensors?

bouwew commented 2 years ago

One more suggestion: in python_luchtmeetnet use aiohttp or httpx instead of requests. These are async implementations, like HA Core is. We (code-owners of plugwise and plugwise-beta) got the same suggestion from the Core devs. See https://github.com/plugwise for our implementation.