Binary rejected by Apple

magus / react-native-facebook-login

React Native component wrapping the native Facebook SDK login button and manager

MIT License

1.24k stars 328 forks source link

Binary rejected by Apple #155

Open ssmlee04 opened 7 years ago

ssmlee04 commented 7 years ago

From Apple
Performance - 2.5.1

Your app uses or references the following non-public APIs:

: setResult: 

The use of non-public APIs is not permitted on the App Store because it can lead to a poor user experience should these APIs change.

I search the term setResult and I think this belongs to the Facebook login package that I was using

xxxx$ grep -Rnis 'setResult:' *
Binary file ios/FBSDKCoreKit.framework/FBSDKCoreKit matches
Binary file node_modules/react-native-facebook-login/FacebookSDK/FBSDKCoreKit.framework/FBSDKCoreKit matches

I am using react-native-facebook-login v1.3.0. And my RN is 0.31.0. Thanks.

zeeshansshaikh commented 7 years ago

i got the same issue did you find the solution ?

ssmlee04 commented 7 years ago

no not yet. I am also waiting for updates. :p

choimyungji commented 7 years ago

i got the same issue too.

lwhiteley commented 7 years ago

Maybe the lib needs to be updated

On Sat, Sep 10, 2016, 9:37 PM choimyungji notifications@github.com wrote:

i got the same issue too.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/magus/react-native-facebook-login/issues/155#issuecomment-246156241, or mute the thread https://github.com/notifications/unsubscribe-auth/AF02eVjgm_T2pTyqEz0NOGDIKeYB8_9bks5qo1tTgaJpZM4J2rsO .

Regards Layton Whiteley

choimyungji commented 7 years ago

the symbol 'setResult' that facebooksdk has loaded in my binary. so i tried remove link option '-all_loads' and i see no 'setResult' symbol my binary i'll register this binary to app store

thanks.

choimyungji commented 7 years ago

i removed -all_load option and i found no setResult on 'nm' command but found on 'strings' command. i'll check more again. sorry

ssmlee04 commented 7 years ago

Are you doing something with objective C when you say you removed -all_load option?

robertkeizer commented 7 years ago

Just to chime in, my company has hit the same rejection.

AxiomxCell commented 7 years ago

Our app version update got rejected with the same issue. Facebook has to update the library ASAP.

choimyungji commented 7 years ago

Ah.. I'm waiting review on my app...

mvoong commented 7 years ago

We also had the same issue yesterday. As it's a very generic name, let's all please appeal to get them to remove the symbol name from their blacklist. We also got rejected for the symbol "displayName", which in my opinion is also very generic.

ssmlee04 commented 7 years ago

I submitted a new version a few days ago. As stupid as this may sound it passed checking this time even though my app still uses the Facebook SDK. I guess we should just keep submitting new builds and at the same time appeal for them to change.

mvoong commented 7 years ago

Our app just got approved after appealing