search

magus / react-native-facebook-login

React Native component wrapping the native Facebook SDK login button and manager
MIT License
1.24k stars 327 forks source link

Exception when rendering login button (FBLoginManager.getCredentials) #8

Closed madjam002 closed 9 years ago

madjam002 commented 9 years ago

I get the following error when rendering the login button using the code in the README

Screenshot

As far as I'm aware, I've setup the library correctly and added the correct keys to my plist file. FBLoginManager.getCredentials seems to be causing the problem.

magus commented 9 years ago

Can you open the example project and let me know if that fails? If it does send me your package.json so I can try to reproduce the issue. If it doesn't then you can paste your code so I can try to debug.

madjam002 commented 9 years ago

Can't build the example project - I get the error /react-native-facebook-login/example/iOS/AppDelegate.m:13:9: 'FBSDKCoreKit/FBSDKCoreKit.h' file not found

I'm new to iOS development so I'm not entirely sure what I'm doing, but I did npm install in the examples folder and the react-native-facebook-login root too. The example package.json appeared to use an out of date version of react-native-facebook-login, upgrading it didn't help. The example project also links the FBSDK frameworks which I thought would have been the problem, so I'm a bit unsure about this...

EDIT: Removing the FBSDK code from AppDelegate.m gives me this

ld: warning: directory not found for option '-F/Users/noah/github/react-native-facebook-login/FacebookSDK'
ld: framework not found Bolts
clang: error: linker command failed with exit code 1 (use -v to see invocation)
magus commented 9 years ago

I'm new to iOS development too, so thanks for bearing with me!

I've corrected the framework search paths which were incorrectly set to absolute paths by XCode, which should resolve the example project failing to build. In addition, the example will now use the latest 0.* release.

Finally, your initial issue was totally due to a bug I introduced just the day before which I've squashed and it should get picked up as I push here in a moment.

Thanks!

madjam002 commented 9 years ago

@magus Ah nice, thanks for the update, everything is working fine now! :D Cheers for the great library.

magus commented 9 years ago

Glad to hear that! :+1: