search

magussiro / cakejs

Automatically exported from code.google.com/p/cakejs
0 stars 0 forks source link

quadraticLengthPointAngle/cubicLengthPointAngle argument mismatch #45

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago 
Disclaimer: I'm new to code.google.com so I might have the process wrong.

I'm new to cakeJS but reading through the cake.js source and there seems to be 
a small typo in Curves.quadraticLengthPointAngle:

quadraticLengthPointAngle : function(a,b,c,lt,error) {
    var p1 = this.linePoint(a,b,2/3)
    var p2 = this.linePoint(b,c,1/3)
    return this.cubicLengthPointAngle(a,p1,p2,c, error)
  }

Should the return statement read "return 
this.cubicLengthPointAngle(a,p1,p2,c,lt, error)" instead?

... I'm also new to javascript so I might have missed how you were applying 
variadic arguments for Curves.cubicLengthPointAngle.

Thanks for developing this project!

Original issue reported on code.google.com by justin.c...@gmail.com on 26 Nov 2011 at 9:40