Allowing to larget image_id values with uint64.

magwyz / pastec

Image recognition open source index and search engine

http://pastec.io

GNU Lesser General Public License v3.0

620 stars 175 forks source link

Allowing to larget image_id values with uint64. #47

Closed erogol closed 7 years ago

erogol commented 7 years ago

Don't you think it is better to use larger values for image_id. I like to ought this change but what parts of the code depended to that change? Any help would be great.

bperel commented 7 years ago

The structure of the image identifier seems to be defined in include/searcher.h. I would suggest to change it there and apply the type change where needed, for instance src/orb/orbindex.cpp

magwyz commented 7 years ago

Be also aware that this size influences the size of the index in the RAM and on the disk. If I remember well, the loader and the writer must also be modified.