Open mahadhir247 opened 4 months ago
Hello, thank you for raising this issue.
As mentioned in the bug report, the implementation logic for findAppt
is present. The general implementation logic for findPatient
, at the structural level as covered in the DG, is similar to that of findAppt
.
Based on the requirements defined by the teaching team previously:
There is no need to document every feature.
The team decided that given the similarities of findAppt
and findPatient
, developers that understand how findAppt
works will find that findPatient
works similarly. In fact, there is no significant value in including the implementation of findPatient
on top of findAppt
. The learning curve is not steep.
Hope this clarifies.
Response rejected.
In any case, the severity was dropped to severity.Low as at best, it is a minor inconvenience.
Team chose [response.Rejected
]
Reason for disagreement: It is understandable that you did not include implementation of the patient commands since they are similar to the appt command. However, it would have been helpful to include a note somewhere that the designs for the functions were similar in the DG. According to the FAQ, the DG is meant to help developers. As a developer, it was initially confusing to read the DG and:
As such, it did result in having to go through the code base to compare the designs myself to indeed verify that it was similar. I do agree that the severity could be lowered though.