search

mahaker / esbuild-gas-plugin

esbuild plugin for Google Apps Script.
MIT License
33 stars 7 forks source link

Add Deno support #5

Closed takker99 closed 3 years ago

takker99 commented 3 years ago

Proposal Changes

mahaker commented 3 years ago

thanks to your contributions! I'll confirm PR.

Throwing error when outfile not specified, is looks good!! I'll apply that to index.js as well.

mahaker commented 3 years ago

I checked PR, looks good! https://github.com/mahaker/esbuild-gas-plugin/tree/review-pr5/pr5

Could you rebase to one commit?

takker99 commented 3 years ago

I'm sorry to be late for the reply. I'm not sure I understand what you mean, because I don't know about git rebase(I'm not master git at all...).

Is this the same way you want me to do?

  1. git switch feature/deno
  2. git rebase -i HEAD~5
  3. follow a wizard and squash all commits
  4. git push -f origin feature/deno
mahaker commented 3 years ago

That's right! 💯

takker99 commented 3 years ago

Thanks! I've rebased.

mahaker commented 3 years ago

Great!! I'll merge this and release deno support!