search

maharmstone / btrfs

WinBtrfs - an open-source btrfs driver for Windows
GNU Lesser General Public License v3.0
5.89k stars 225 forks source link

Corruption after light usage, is it normal? #474

Open derinsh0 opened 2 years ago

derinsh0 commented 2 years ago

I’ve been using winbtrfs years before, on an hdd. Since I got a new NVMe SSD I formatted it to btrfs.

I used space cache v2, and zstd:1 compression, and formatted via Windows. I also used xxhash since I remembered all those CRC errors from winbtrfs previously. I moved a few games over, all looked fine, I copied a game mods folder, with mods for games such as Fallout. The first issue I noticed was that the game would crash, just moving the mod folder out of btrfs and keeping the game install on btrfs made the game launch.

The second more serious issue I got was right clicking a file to check its path, resulting in a BSOD, this did not happen again.

Other than that I haven’t noticed issues, but I booted into Linux and did btrfs check with close to 50k bad file extent. Root 286 is my Games subvol. btrfs-check.txt

derinsh0 commented 2 years ago

I should update on this issue. I do not know whether this is an issue in btrfs upstream or winbtrfs @maharmstone

The actual problem was that disabling COW should not allow for compression. So when selecting both Disaple Copy-On-Write, and enabling Compress, these warning messages appear. Since I found this bug in the main btrfs driver maybe it’s an issue for them.

maharmstone commented 2 years ago

Thanks @psisis.

The actual problem was that disabling COW should not allow for compression.

Which makes sense, but I'll need to remind myself of what my driver actually does...

derinsh0 commented 2 years ago

Thanks @psisis.

The actual problem was that disabling COW should not allow for compression.

Which makes sense, but I'll need to remind myself of what my driver actually does...

Before closing this, I’ll refer to the bug report at https://www.spinics.net/lists/linux-btrfs/msg114619.html

The change that don't allow allow compression if the inode has NODATASUM
option is introduced in commit 42c16da6d684 ("btrfs: inode: Don't
compress if NODATASUM or NODATACOW set"), which is from v5.2 in 2019.

Thus such old fs indeed can be affected.

Since I don’t know enough about the filesystem I can’t decide if this is a legitimate issue for winbtrfs

derinsh0 commented 2 years ago

@maharmstone Latest changelog specifies that compression won’t be allowed for No-COW. Should we close this issue?

1.8.1 might have solved my other issues as well, I will have to test them out.