maheshj01 / navbar_router

A Navbar widget for advanced usecases to improve user experience and save your time.
https://docs.maheshjamdade.com/navbar_router/
MIT License
29 stars 7 forks source link

Elevation doesn't work on the NavBarDecoration #12

Open tushar4303 opened 1 year ago

tushar4303 commented 1 year ago

The background behind the navigation bar and the bottom nav bar are both white in my UI, which makes it really hard to notice the navbar's starting point and the elevation doesn't seem to work in order to add the shadow to the navbar

Steps to reproduce the behavior:

  1. Changing value on the elevation property doesn't make ui shadow show up

Expected behavior A shadow should have appeared at the top of the NavBar

Screenshots

Smartphone (please complete the following information):

maheshj01 commented 1 year ago

Hi, @tushar4303 Thanks for filing the issue. That definitely isn't intended behavior. Feel free to file a PR if you are interested and I will be happy to review it.

maheshj01 commented 1 year ago

@tushar4303 Upon further investigation I found that this bug is currently in the flutter framework see https://github.com/flutter/flutter/issues/27585#issuecomment-1364030238, Unfortunately, we will have to wait until that is fixed rather than pushing some work around.

tushar4303 commented 1 year ago

Alright, thank you for investigating, i really appreciate your hard work, this package really saved me a ton of time.

Also i was wondering, is this package deep Linking ready, or can we expect a feature update for the same.

Since i switched from various other options, due to their complexity in setup process.

maheshj01 commented 1 year ago

@tushar4303 there are no such plans as of now until the package is stabilized with its basic features. However, feel free to file a new issue with all the requested details. I or someone might consider working on it if the proposal sounds plausible.

bebaoboy commented 7 months ago

@tushar4303 Upon further investigation I found that this bug is currently in the flutter framework see https://github.com/flutter/flutter/issues/27585#issuecomment-1364030238, Unfortunately, we will have to wait until that is fixed rather than pushing some work around.

Did you try this simple workaround? Issue comment

maheshj01 commented 7 months ago

Workarounds like that will add unncessary tech debt. I think we should not add workarounds unless the issue is a severe blocker or affects a lot of users.

bebaoboy commented 7 months ago

I think that comment only said to wrap the navbar with a top padding... it's not so complicated

maheshj01 commented 7 months ago

Yes I understand that, but I am guessing it could potential affect the layout of navbar considering we have multiple types of Navbar.

bebaoboy commented 7 months ago

Your concern is valid, yeah. I'll test that method on different navbar types if I have free time and tell you the result. Thanks!