support dot and badge in nav bar items

maheshj01 / navbar_router

A Navbar widget for advanced usecases to improve user experience and save your time.

https://docs.maheshjamdade.com/navbar_router/

MIT License

29 stars 7 forks source link

support dot and badge in nav bar items #36

Closed joshuamoreno1 closed 7 months ago

joshuamoreno1 commented 12 months ago

support dot and badge in nav bar items

List which issues are fixed by this PR. You must list at least one issue. https://github.com/maheshmnj/navbar_router/issues/30

Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is [test-exempt].
[x] All existing and new tests are passing using flutter test

If you need help, consider pinging the maintainer @maheshmnj

maheshj01 commented 12 months ago

Hello @joshuamoreno1, thank you so much for the PR, Can you please add some basic sanitary tests?

You can refer badge tests here

Let me know if you need any further help

maheshj01 commented 12 months ago

Just noticed the tests are failing let me help you with that.

Edit: I have added a few comments lmkwyt.

bebaoboy commented 7 months ago

Hello, I happen to come across this package and found out a way to cleanly integrate badges with animations into the navbar, using a 3rd party badges of flutter themselves and some tweaks 😄

I can make a PR, but I wanna ask you first @maheshmnj if this feature hás already been implemented in the next update.

If not yet, is it okay for navbar_router have a dependency on the badges package (although the badges itself doesn't depend on anything else)

Thank you! Have a good day!

maheshj01 commented 7 months ago

Hi @bebaoboy, This feature is not implmented yet and if you are interested you are welcome to make a PR and dependency on badges sounds good to me.

maheshj01 commented 7 months ago

Closing this PR since there has been no update for a long time incase @joshuamoreno1 you are still interested to work on this PR please feel free to reopen and make the update.