search

maheshj01 / searchfield

A highly customizable simple and easy to use flutter Widget to add a searchfield to your Flutter Application.This Widget allows you to search and select from list of suggestions.
MIT License
84 stars 63 forks source link

[Proposal] Add height parameter for suggestion dialog #164

Closed elijahpraise closed 3 months ago

elijahpraise commented 3 months ago

When the suggestions are past the max suggestions in viewport, the dialog is scrollable, while this is fine, I humbly request that you add a nullable height parameter that will default to the total height if not specified.

maheshj01 commented 3 months ago

Hi @elijahpraise , Thanks for filing the issue. Have you tried using maxSuggestionBoxHeight parameter?

elijahpraise commented 3 months ago

Just seeing this parameter now. Thanks so much. I saw it on the latest release

On Thu, Aug 8, 2024, 3:09 PM Mahesh Jamdade @.***> wrote:

Hi @elijahpraise https://github.com/elijahpraise , Thanks for filing the issue. Have you tried using maxSuggestionBoxHeight parameter?

— Reply to this email directly, view it on GitHub https://github.com/maheshj01/searchfield/issues/164#issuecomment-2275930013, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUB36M6QFQVSP64YGAW2WNDZQN323AVCNFSM6AAAAABMF25CBSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENZVHEZTAMBRGM . You are receiving this because you were mentioned.Message ID: @.***>

maheshj01 commented 3 months ago

Closing as the feature already exist, Incase you encounter a bug or have a feature request feel free to file a new issue.

Best, Mahesh

elijahpraise commented 3 months ago

Thanks, I will.

On Thu, Aug 8, 2024, 10:56 PM Mahesh Jamdade @.***> wrote:

Closing as the feature already exist, Incase you encounter a bug or have a feature request feel free to file a new issue.

Best, Mahesh

— Reply to this email directly, view it on GitHub https://github.com/maheshj01/searchfield/issues/164#issuecomment-2276735062, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUB36M447F7BU4FQ7N3WEJTZQPSQPAVCNFSM6AAAAABMF25CBSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENZWG4ZTKMBWGI . You are receiving this because you were mentioned.Message ID: @.***>