maheshmnj / vocabhub

An app to help you build your vocabulary. This app contains 800+ curated GRE words
https://vocabhub.web.app/
Apache License 2.0
46 stars 10 forks source link

Word and Synonym should not be same #11

Closed maheshmnj closed 1 year ago

maheshmnj commented 2 years ago

Users can add the same word as synonym

To Reproduce Steps to reproduce the behavior:

  1. Add / Edit a word/
  2. Add the same synonym as word
  3. save/update

Expected behavior Word and synonym should not be the same

daumienebi commented 1 year ago

Hey there!, are these issues still really open to be fixed?

maheshmnj commented 1 year ago

Hey @daumienebi, Yes, I intend to fix them, But unfortunately I cannot commit an eta. The latest updates to the app are here https://github.com/maheshmnj/vocabhub/tree/redesign. And the latest app is in the playstore. I am open to contributions though.

Edit: Hopefully I can find some time to fix this by end of this month.

daumienebi commented 1 year ago

Alright @maheshmnj, i am trying to improve my flutter skills and i'm about to complete my first app to be published to the Play Store and i found your StackOverFlow profile where you answered a question that helped me so thanks!. I am open to contributing to your app in any possible way. I understand that newer commits are no longer pushed to the master branch right?

maheshmnj commented 1 year ago

i found your StackOverFlow profile where you answered a question that helped me so thanks!

Nice to hear that!

I understand that newer commits are no longer pushed to the master branch right?

Actually, on master, I have a multiplatform app (android/web app) and on the redesig branch, it only is supported for mobile so I won't be merging the code to master unless the redesign branch supports web. If you ever make a PR please make it to the redesign branch. I will update the contributing guidelines soon

daumienebi commented 1 year ago

Alright :)

daumienebi commented 1 year ago

Hey there, i wanted to ask a question about the usage of Supabase in this project. Are you personally hosting the database?

maheshmnj commented 1 year ago

@daumienebi No the hosting is taken care of by Supabase itself, I am just using the supabase client to interact with the database.

daumienebi commented 1 year ago

@maheshmnj Ok,thanks for the information.

maheshmnj commented 1 year ago

This has been fixed in the linked commit and will be released in the upcoming version

daumienebi commented 1 year ago

@maheshmnj Alright, nice to hear that :). There's one problem in the current app that is available on the Playstore. When i try to sign in with a Google account, i get the "Failed to register new user" error.

maheshmnj commented 1 year ago

@daumienebi that is strange! I just verified with two different accounts and it seems to work for me. Is the issue with any specific Google account on your end?

daumienebi commented 1 year ago

@maheshmnj Hey there, sorry for not responding all this while, i remembered this stuff once again and i tried with two different google accounts but it's not signing in. I dont know if any of those accounts were mistakenly blocked or something but i get the 'Failed to register new user' error. Here's a screenshot :

Screenshot_2023-05-17-01-15-01-131_com vocabhub app

maheshmnj commented 1 year ago

Thanks for reporting @daumienebi, Would you please create a new issue, I would love to take a look.

daumienebi commented 1 year ago

@maheshmnj Alright, i have created the issue here : #23