RunInstances fails with addressingtype problem

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Call RunInstances with a LaunchConfiguration parameter against EC2
2.
3.

What is the expected output? What do you see instead?
Exception is thrown

Caused by: com.xerox.amazonws.ec2.EC2Exception: Client error : Addressing
type must be 'public'

The request over the wire looks like:

GET /?AWSAccessKeyId=XXXX&Action=RunInstances&AddressingType=true&ImageId=...

Note "AddressType=true"

Amazon returns:

<Response><Errors><Error><Code>InvalidParameterCombination</Code><Message>Addres
sing
type must be 'public'</Message></Error></Errors>

Looks like a regression from r287. I suspect we need to change 
ReservationDescription runInstances(LaunchConfiguration lc). I'm not
certain, but from reading issue 60 it seems like the intended behavior for
this function is something like:

params.put("AddressingType", lc.isPublicAddressing() ? "public" : "private");

Original issue reported on code.google.com by gabriel....@gmail.com on 16 Oct 2009 at 4:57

[GoogleCodeExporter]

This is with the r292 in SVN

Original comment by gabriel....@gmail.com on 16 Oct 2009 at 4:58

[GoogleCodeExporter]

Ahhh. crappy cut-paste. Yes, this boolean should have been public/private 
instead. I'll get that fixed. I'm in the 
middle of additions for the new WSDL. Given where I'm at, I can do a checkin 
since I've only added a few things, 
and not all of the snapshot sharing yet. I'll run some tests before doing the 
checkin.

Original comment by dkavan...@gmail.com on 16 Oct 2009 at 5:06

• Changed state: Started

[GoogleCodeExporter]

fixed in svn r294

Original comment by dkavan...@gmail.com on 16 Oct 2009 at 5:45

• Changed state: Fixed